Skip to content

Restructure campaign designer to match workflow designer two-mode pattern #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pelikhan merged 2 commits into from
Dec 19, 2025
Merged

Restructure campaign designer to match workflow designer two-mode pattern #6996

pelikhan merged 2 commits into from
Dec 19, 2025

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025 •
edited
Loading

The campaign designer custom agent used an outdated single-mode structure while the workflow designer had evolved to support both automated issue-form-based generation and interactive conversational modes. This inconsistency made the campaign system harder to use and maintain.

Changes

  • Restructured campaign designer template to implement two-mode operation:

    • Issue Form Mode: Parses GitHub issue forms and generates complete .campaign.md files non-interactively
    • Interactive Mode: Conversational agent that guides users through campaign spec creation step-by-step

  • Added agent file cleanup: New cleanupOldAgentFile() function migrates from old campaign-designer.agent.md to agentic-campaign-designer.agent.md naming convention

  • Enhanced campaign spec guidance: Added comprehensive field documentation, compilation instructions, and PR creation workflow matching workflow designer patterns

Example Structure

### Mode 1: Issue Form Mode (Non-Interactive)

1. Parse issue form data (campaign_name, campaign_description, additional_context)
2. Generate complete .campaign.md with frontmatter and body
3. Compile campaign to generate orchestrator workflow
4. Create PR with both .campaign.md and generated files

### Mode 2: Interactive Mode (Conversational)

- Engage in back-and-forth dialogue
- Guide through campaign spec fields (id, name, workflows, owners, risk-level, etc.)
- Use GitHub Copilot CLI-style conversational format

The campaign generation process continues to use BuildOrchestrator() and integrates seamlessly with the compile pipeline.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login eam.git eam.git 0/x64/bin/node -d ../../**/*.json 64/bin/go /opt/hostedtoolcache/go/1.25.0/x64/pkg/tool/linuconfig -V=f�� 62/create_code_scanning_alert.js o (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login it/ref/tags/v5 --version ache/go/1.25.0/x64/pkg/tool/linux_amd64/link l log 64/bin/go ache/go/1.25.0/x64/pkg/tool/linux_amd64/link -o f/tags/v6 -importcfg e/git-remote-https -s -w -buildmode=exe e/git-remote-https (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub/workflows -extld=gcc 64/bin/node 83417d4046b06ab70bdd08539ce1a2dcfbd/log.json GO111MODULE e git 0/x6�� om/github/codeql-action.git config (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Restructure the campaign designer to work similarly to the workflow designer custom agent and make use of this in the campaign generation process so that our workflow/campaign system is aligned and consistent.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@mnkiefer
Restructure campaign designer to match workflow designer pattern with…
42ab76d 
… two modes

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Restructure campaign designer for consistency with workflow designer Restructure campaign designer to match workflow designer two-mode pattern Dec 19, 2025
Copilot AI requested a review from mnkiefer December 19, 2025 19:40
@pelikhan pelikhan marked this pull request as ready for review December 19, 2025 19:47
@pelikhan pelikhan added the smoke label Dec 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

✅ Firewall validation complete... Smoke Codex Firewall confirmed network sandboxing is operational. 🛡️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited by agentic-workflows-dev bot
Loading

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

🤖 DIAGNOSTIC COMPLETE: Smoke Copilot No Firewall STATUS: ALL_UNITS_OPERATIONAL. MISSION_SUCCESS.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025 •
edited
Loading

🎉 Yo ho ho! Smoke Copilot Safe Inputs found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Smoke Test Results (Run 20380823772)

Last 2 Merged PRs:

✅ GitHub MCP - PRs retrieved
✅ File Writing - Test file created
✅ Bash Tools - File verified
✅ GitHub MCP Default - get_me correctly blocked
✅ Cache Memory - Cache file created
✅ Available Tools - All tools accessible

Status: PASS
Author: @Copilot | Assignees: @mnkiefer @Copilot

📰 BREAKING: Report filed by Smoke Copilot fer issue #6996 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Smoke Test Results

GitHub MCP: ✅ PR #405, PR #404
File Writing: ✅ Created and verified
Bash Tool: ✅ File read successful
Serena MCP: ✅ Classes listed
Safe Input gh: ✅ Issues retrieved

Overall Status: PASS

Ahoy! This treasure was crafted by 🏴‍☠️ Smoke Copilot Safe Inputs fer issue #6996 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Smoke Test Results - Copilot Engine

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP: Retrieved PR data successfully
  • ✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-copilot-20380823815.txt
  • ✅ Bash Tool: File read verification passed
  • ✅ Playwright MCP: Navigated to github.com, title contains "GitHub"
  • ❌ Safe Input gh Tool: Tool not available (expected - not configured)

Status: PASS (4/5 core tests passed, gh tool absence documented)

🤖 DIAGNOSTIC REPORT GENERATED BY Smoke Copilot No Firewall fer issue #6996 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Fix workflow issue form to generate .md and .lock.yml files like campaign generator
Update CLI tools: Claude Code 2.0.73, Copilot 0.0.371, Codex 0.75.0, GitHub MCP Server v0.26.3
OpenAI domain access: ❌ (DNS blocked)
GitHub MCP query: ✅
File write/read: ✅
Blocked domain (example.com): ✅ (blocked as expected)
Network: SANDBOXED
Overall: FAIL

🔥 Firewall tested by Smoke Codex Firewall fer issue #6996 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Smoke Test Results - Claude Engine

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP: Retrieved recent PRs
  • ✅ File Writing: Created /tmp/gh-aw/agent/smoke-test-claude-20380823763.txt
  • ✅ Bash Tool: Verified file contents
  • ✅ Playwright MCP: Navigated to GitHub, title contains "GitHub"
  • ✅ Cache Memory: Created /tmp/gh-aw/cache-memory/smoke-test-20380823763.txt
  • ❌ Safe Input gh Tool: Tool not available in this environment

Overall Status: PASS (5/6 tests passed)

💥 [THE END] — Illustrated by Smoke Claude fer issue #6996 🗺️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

PRs reviewed: 6994 "Document CLI version changes: Codex 0.74.0+ and GitHub MCP Server v0.26.0+"; 6992 "[WIP] Fix markdown lint issues and inconsistencies"
GitHub MCP last-2 PRs ✅
Agent file write/read ✅
Playwright title ✅
Cache memory file ✅
safeinputs-gh issues list ❌ (tool unavailable in this run)
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex fer issue #6996 🗺️

@pelikhan pelikhan merged commit 68981cf into main Dec 19, 2025
207 checks passed
@pelikhan pelikhan deleted the copilot/restructure-campaign-designer branch December 19, 2025 19:51
@github-actions github-actions bot mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnkiefer mnkiefer Awaiting requested review from mnkiefer

Assignees

@mnkiefer mnkiefer

Copilot code review Copilot

Labels

smoke smoke-claude smoke-copilot smoke-copilot-no-firewall

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pelikhan @mnkiefer